https://bugs.kde.org/show_bug.cgi?id=453694

            Bug ID: 453694
           Summary: Typo in LatencyPolicy
           Product: kwin
           Version: 5.24.5
          Platform: Other
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: compositing
          Assignee: kwin-bugs-n...@kde.org
          Reporter: malted....@gmail.com
  Target Milestone: ---

SUMMARY
I think there are some oversights in the implementation of the LatencyPolicy
for the compositing:
a) The variable for the lowest setting is set to "LatencyExtremelyLow" here:
     https://invent.kde.org/plasma/kwin/-/blob/master/src/kwin.kcfg#L249
and here:
    
https://invent.kde.org/plasma/kwin/-/blob/master/src/kcmkwin/kwincompositing/kwincompositing_setting.kcfg#L57

But the enum and actual switch statement have a typo. It's called
"LatencyExteremelyLow" with an additional "e", see:
    https://invent.kde.org/plasma/kwin/-/blob/master/src/renderloop.cpp#L61
and 
    https://invent.kde.org/plasma/kwin/-/blob/master/src/options.h#L49

STEPS TO REPRODUCE
1. Look into the sourcecode

OBSERVED RESULT
There is a typo in two places. (I can't check if this actually leads to the
setting not being applied correctly.)

EXPECTED RESULT
Everywhere should be the same correct string: "LatencyExtremelyLow"

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Tumbleweed 20220509
(available in About System)
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.2


ADDITIONAL INFORMATION
Another thing I noticed (I can open a seperate issue for that if you like) were
the following outputs in my journalctl directly after start/login:
> Mai 12 12:53:18 localhost.localdomain kwin_wayland[3792]: 
> QMetaProperty::read: Unable to handle unregistered datatype 
> 'XwaylandCrashPolicy' for property 'KWin::Options::xwaylandCrashPolicy'
> Mai 12 12:53:18 localhost.localdomain kwin_wayland[3792]: 
> QMetaProperty::read: Unable to handle unregistered datatype 'LatencyPolicy' 
> for property 'KWin::Options::latencyPolicy'
> Mai 12 12:53:18 localhost.localdomain kwin_wayland[3792]: 
> QMetaProperty::read: Unable to handle unregistered datatype 
> 'RenderTimeEstimator' for property 'KWin::Options::renderTimeEstimator'
I think this is caused when the .kwinrc is being read and I can only guess that
this is caused by the enums having no "usual" datatypes assigned? Like saying
>     LatencyExteremelyLow = 1,
here https://invent.kde.org/plasma/kwin/-/blob/master/src/options.h#L49
I've also no idea if this prevents the variables in .kwinrc from being read and
applied correctly?!

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to