https://bugs.kde.org/show_bug.cgi?id=452729
--- Comment #11 from Méven Car <meven....@kdemail.net> ---
(In reply to Harald Sitter from comment #10)
> This seems to do the trick
>
> @@ -245,9 +245,7 @@ void KIO::MimeTypeFinderJobPrivate::scanFileWithGet()
> m_suggestedFileName =
> job->queryMetaData(QStringLiteral("content-disposition-filename"));
> }
>
> - if (!m_url.isLocalFile()) { // #434455
> - job->putOnHold();
> - }
> + job->kill();
> q->emitResult();
> });
> }
Very interesting.
https://bugs.kde.org/show_bug.cgi?id=434455 already circumvented it for local
files but what was the justification for it in the first place ?
Maybe that's just old design but better run tests & have a good look at the
code before making too many assumptions.
It seems
https://invent.kde.org/frameworks/kio/-/blob/6b1fd98193e08b22dbf77e9e33606b2b1800ef88/src/core/slavebase.cpp#L727
we had a way to get out of the loop but the inner loop does not break, it
seems. The bug might be there in fact.
Missing
if (cmd == CMD_NONE) {.
break;
}
?
Maybe a good time to open a MR and cc David.
--
You are receiving this mail because:
You are watching all bug changes.
