https://bugs.kde.org/show_bug.cgi?id=452554
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/plas
| |ma/plasma-workspace/commit/
| |5430c3a029590f824419dce5774
| |a5e10efd72df5
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Version Fixed In| |5.24.5
--- Comment #5 from Nate Graham <n...@kde.org> ---
Git commit 5430c3a029590f824419dce5774a5e10efd72df5 by Nate Graham, on behalf
of David Edmundson.
Committed on 21/04/2022 at 17:17.
Pushed by ngraham into branch 'master'.
applets/digital-clock: Fix date drift
dateTimeChanged is called every second. This in turn checks if the date
has changed. If so we call setupLabels which updates the clock.
The date label used to use main.currentTime which is a value set in the
binding of the timeLabel's text property. The order of this being
updated vs running this code is undefined.
Bug 1: We compare an ever so slightly different date source to the one
used in the date text label.
Bug 2: We are not necessarily updating the date label with the most
updated time.
Overall we can't mix declarative and imperative design patterns. This
patch commits to being imperative and introduces a function to get the
current time so that the date label and time label will always get the
most up to date value even if they update from different trigers.
FIXED-IN: 5.24.5
M +14 -15 applets/digital-clock/package/contents/ui/DigitalClock.qml
https://invent.kde.org/plasma/plasma-workspace/commit/5430c3a029590f824419dce5774a5e10efd72df5
--
You are receiving this mail because:
You are watching all bug changes.
