https://bugs.kde.org/show_bug.cgi?id=341092
Matěj Laitl <ma...@laitl.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |http://commits.kde.org/amar
| |ok/0e760e5f8d06d00e084c14b6
| |4875f58bb42bd8f1
Version Fixed In| |2.9
CC| |ma...@laitl.cz
See Also| |https://bugs.kde.org/show_b
| |ug.cgi?id=226144
--- Comment #4 from Matěj Laitl <ma...@laitl.cz> ---
I think this may be resolved by work done on bug 226144:
> Git commit 0e760e5f8d06d00e084c14b64875f58bb42bd8f1 by Matěj Laitl, on
> behalf of Stefano Pettini.
> Committed on 20/08/2016 at 10:37.
> Pushed by laitl into branch 'master'.
>
> Organize tracks / Guess tags presets persisted properly.
>
> FilenameLayoutWidget is reworked to fix an old bug regarding the presets
> not being saved properly, that I was also able to reproduce.
>
> Logic is not a bit more "linear". Presets are shared between "Organize
> tracks"
> and "Guess tags" dialog. If this is not what is wanted, it can be easily
> changed,
> just let me know. Presets are saved as soon as they are added, updated or
> deleted.
> It is not anymore necessary to accept the dialog to save eventual changes.
>
> The preset used is not saved with the marker "#DELIM#selected" anymore.
> Presets are just presets. The one used is matched on the fly using the custom
> preset field. If a preset matches the custom preset field, it's considered
> selected. Users can of course create custom presets as before.
> While presets are shared between the two dialogs, custom presets are not.
>
> Add/Update/Remove work properly. Clicking on a preset name in the combobox
> resets the custom pattern to the preset value, this is a new feature,
> before it was not possible.
>
> It's a bit difficult to explain, but UX is more natural, just give it a try.
>
> A lot of testing was done (by Stefano), like:
> - adding/updating/removing presets.
> - if settings are persisted and shared when dialogs are cancelled or
> accepted.
> - if custom patterns are persisted and not shared.
> - resetting a modified pattern to its defualt.
> - cancelling dialogs, modified presets are kept but custom patterns are not.
>
> REVIEW: 128565
>
> M +3 -1 ChangeLog
> M +1 -1 src/amarokconfig.kcfg
> M +0 -5 src/dialogs/OrganizeCollectionDialog.cpp
> M +0 -2 src/dialogs/OrganizeCollectionDialog.h
> M +53 -49 src/widgets/FilenameLayoutWidget.cpp
> M +4 -6 src/widgets/FilenameLayoutWidget.h
>
> http://commits.kde.org/amarok/0e760e5f8d06d00e084c14b64875f58bb42bd8f1
Please re-test with current git master and reopen if it is not the case.
--
You are receiving this mail because:
You are watching all bug changes.
