https://bugs.kde.org/show_bug.cgi?id=414904
--- Comment #9 from snx <s...@mailbox.org> ---
Git commit 1c15548132621f0a543572338402ff302c621ae1 by snooxx 💤.
Committed on 17/03/2022 at 01:36.
Pushed by meven into branch 'master'.
KExtendableItemDelegate: Fix HiDPI positioning of indicator arrows
After fixing pixelated indicator arrows in `KShortcutsEditorDelegate`
(i.e. a subclass, see frameworks/kxmlgui!104) used in the
"Configure Keyboard Shortcuts" dialog, they were not drawn centered
anymore, e.g. slightly moved upwards. The same problem can be observed
in the download list of KGet.
This is because the increased size of the pixmap is not accounted for.
By transforming the pixmap size to device independent dimensions
again, as used in the positioning calculations, the arrows will finally
be shown correctly.
Note that running `KItemViews` in conjunction with a version of
`KXmlGUI` not including the fix will still work fine, since the
`devicePixelRatio` will only ever be set to `1` in that case.
Test Plan:
- Launch `QT_SCALE_FACTOR=1.7 ./bin/kxmlguiwindowtest`
(from KXmlGui, including the fix mentioned above).
- Open "Configure Keyboard Shortcuts" dialog.
- Arrows in "Shortcut" column positioned correctly, for both their
expanded and collapsed states.
- Test with `-style Fusion` and other scaling factors, too.
- `QT_SCALE_FACTOR=1.7 kget`, start download, observe indicator arrow
in download list.
M +10 -8 src/kextendableitemdelegate.cpp
https://invent.kde.org/frameworks/kitemviews/commit/1c15548132621f0a543572338402ff302c621ae1
--
You are receiving this mail because:
You are watching all bug changes.
