https://bugs.kde.org/show_bug.cgi?id=449672
Mark Wielaard <m...@klomp.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Mark Wielaard <m...@klomp.org> ---
(In reply to Carl Love from comment #1)
> Mark, thanks for letting us know about the issue. Let us know if there is
> anything we can do to help verify the fix. Off hand I have nothing to add
> to the fix.
Thanks. Pushed as:
commit fb6a77ed78876083e8ba4c2f92384db5c2e41be8 (HEAD -> master, origin/master,
origin/HEAD)
Author: Mark Wielaard <m...@klomp.org>
Date: Tue Feb 8 16:36:08 2022 +0100
ppc64 --track-origins=yes failure because of bad cmov addHRegUse
For Pin_CMov getRegUsage_PPCInstr called addHRegUse for the dst
register with HRmWrite, but since this is a conditional move the
register could be both read and written (read + write = modify).
This matches the dst of Pin_FpCMov and Pin_AvCMov.
In a very rare case, and only with --track-origins=yes, this
could cause bad code generation.
This is slightly amazing, this code is from 2005 and as far as
I know we never seen an issue with --track-origins=yes on power
before. And I have been unable to come up simple reproducer.
https://bugs.kde.org/show_bug.cgi?id=449672
I have ran various tests and seen no regressions with this change. The bad code
generation is also gone.
The issue is pretty hard to reproduce and I haven't been able to produce a
simple reproducer. If you find
any issues with this code please add to this bug.
--
You are receiving this mail because:
You are watching all bug changes.
