https://bugs.kde.org/show_bug.cgi?id=366713

Boudewijn Rempt <b...@valdyas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |http://commits.kde.org/krit
                   |                            |a/ebc8a43ce07b6152abfb2fb88
                   |                            |509c4bad1439f46

--- Comment #2 from Boudewijn Rempt <b...@valdyas.org> ---
Git commit ebc8a43ce07b6152abfb2fb88509c4bad1439f46 by Boudewijn Rempt.
Committed on 13/08/2016 at 09:14.
Pushed by rempt into branch 'master'.

A line like

QRect rect = temporaryTarget() ? temporaryTarget()->extent() : QRect();

is dangerous, since the paint device might be gone between the check
and the use. It's better to get a local shared pointer to the paint
device and check that.

M  +5    -3    libs/image/kis_paint_layer.cc
M  +10   -6    libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp
M  +9    -5   
plugins/tools/basictools/strokes/move_selection_stroke_strategy.cpp

http://commits.kde.org/krita/ebc8a43ce07b6152abfb2fb88509c4bad1439f46

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to