https://bugs.kde.org/show_bug.cgi?id=448122
Bug ID: 448122
Summary: [Regression] Unchecking "Draw a circle around close
button" does not set it to false in breezerc
Product: Breeze
Version: 5.23.3
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: plasma-b...@kde.org
Reporter: c...@horwell.me
Target Milestone: ---
SUMMARY
In System Settings, under Window Decorations, there is a check box to turn
on/off the circle drawn around the close button. By default, this is checked.
Unchecking this does not write "OutlineCloseButton=false" in breezerc, causing
the circle to be drawn for close tab buttons, with only the circle outline
disappearing on the window decoration's close button, causing this
inconsistency.
>From a VM snapshot, 5.22.5 is a last known good version. 5.23.3 inhibits the
bad behaviour, but it may have regressed as early as 5.23.0.
STEPS TO REPRODUCE
1. Check "Draw a circle around close button" for Breeze's window decoration and
apply.
2. "OutlineCloseButton=true" appears in ~/.config/breezerc
3. Open tabs in Dolphin: both the tab close button and window close button draw
a circle as expected.
4. Uncheck "Draw a circle around close button" and apply.
5. "OutlineCloseButton=true" disappears from ~/.config/breezerc
6. Dolphin's close tab button shows the outline, but does disappear on the
window's close button.
7. Manually add "OutlineCloseButton=false" to ~/.config/breezerc
8. Relaunch Dolphin. Both the close tab buttons and window decorations no
longer draw a circle.
OBSERVED RESULT
Unchecking the option causes the close button shape to be inconsistent across
Breeze. Very confusing as the user tries looking in other areas (like Breeze's
"Application Style") in case there were separate settings for widgets and
window decorations, which is currently not the case.
EXPECTED RESULT
Unchecking the option turns off the circle outline for both widgets (e.g. close
tab) and window decoration's close button.
The feature is functional by manually setting 'false' in ~/.config/breezerc:
```
[Common]
OutlineCloseButton=false
```
It seems like the code may be deleting the line under the assumption that
unchecked values = delete/blank the key, but this doesn't work in this context
as no key = true, so the tab close button will always be drawn unless the user
was aware of the config file or this bug.
SOFTWARE/OS VERSIONS
OS: Arch Linux
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.87.0
Qt Version: 5.15.2
ADDITIONAL INFORMATION
Bug 419474 is related in that this an unexpected link between a window
decoration setting and one that affects the application style too. An idea
could be to add "Draw a circle around close button" to the application style's
settings instead.
--
You are receiving this mail because:
You are watching all bug changes.
