https://bugs.kde.org/show_bug.cgi?id=366366

--- Comment #2 from Harald Sitter <sit...@kde.org> ---
I think you just volunteered to upstream this.

- copyright file is incomplete
- should put examples into -dev package
- should put cmake file into -dev package
- possibly should split qml from actual inputplugin (not actually sure that is
useful though)
- build-depends on kde-pkg-tools but doesn't seem to use it at all
- shouldn't buildpdep on qt5-default
- all qt builddeps should be tightly versioned
- the rules file seems a bit ugh

should export these flags:
export CFLAGS := $(shell dpkg-buildflags --get CFLAGS) $(shell dpkg-buildflags
--get CPPFLAGS)
export CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) $(shell
dpkg-buildflags --get CPPFLAGS)
export LDFLAGS := $(shell dpkg-buildflags --get LDFLAGS) -Wl,--as-needed
export QT_SELECT := qt5

- shouldn't phony override_dh_auto_test or document why that is absolutely
necessary

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to