https://bugs.kde.org/show_bug.cgi?id=417636
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
|eworks/kirigami/commit/67ec |eworks/kirigami/commit/3f19
|2a1873e3d750529043b243043cf |67bc7b9f21b6cb5c7423376fe3c
|d2e2f9ec6 |f79ad5fbd
Status|ASSIGNED |RESOLVED
Version Fixed In|5.89 |5.90
--- Comment #28 from Nate Graham <n...@kde.org> ---
Git commit 3f1967bc7b9f21b6cb5c7423376fe3cf79ad5fbd by Nate Graham.
Committed on 07/12/2021 at 02:48.
Pushed by ngraham into branch 'master'.
PageRowGlobalToolBarUI: don't animate opacity, take two
This work was originally attempted in
67ec2a1873e3d750529043b243043cfd2e2f9ec6 but that had to be reverted as
it caused regressions. This commit atteampts the same fix, but without
any regressions, and based on a better understanding of the problem and
how this fixes it. Details below:
The problem here is that the breadcrumbs view is in a loader that's not
active by default; when the pagerow header style is breadcrumbs, it will
get loaded a few milliseconds after the rest of the page loads. This
causes a brief, barely noticeable but nonetheless noticeable flicker.
The existing code attempts to hide this by animating the opacity.
However this does not work because only the breadcrumbs content is
animated; the background is not. So the breadcrumbs and background have
two different transitions, which looks weird. Even if this were fixed,
there is a bigger conceptual problem: having the background transition
along with the content would make the entire header seem to appear and
disappear.
So the best transition in this case is no transition and an instant
appearance and disappearance. Due to the use of a loader, this cannot be
guaranteed and so there will always be a very brief flicker. This does
not seem fixable without fundamental refactoring of how page headers
work in Kirigami.
Accordingly, this commit simple removes all animated transitions and has
the content appear instantly as soon as the loader is finished loading.
FIXED-IN: 5.90
M +1 -11 src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml
https://invent.kde.org/frameworks/kirigami/commit/3f1967bc7b9f21b6cb5c7423376fe3cf79ad5fbd
--
You are receiving this mail because:
You are watching all bug changes.
