https://bugs.kde.org/show_bug.cgi?id=445408

--- Comment #5 from Tiar <tamtamy.tym...@gmail.com> ---
I, uhh, respectfully disagree with the notion that it's a "workaround" because
it is a fix for a real issue. Here we have two issues:

1) deactivating all resources when you have duplicates (probably caused by the
fact that the first one is disabled because it comes from a disabled bundle,
then the next one is disabled because it's a second one... etc.)

2) not finding the appropriate resource in the model just because it's disabled
or comes from a disabled model. Note that or this to happen you don't need
issue (1); it's enough if you make a preset with some brush tip and then
deactivate that brush tip (note that right now, all presets embed their
dependant resources so you might need to create a preset in earlier versions of
Krita for it, though I think the bundle still puts them alongside presets
anyway...). Hence, issue (2) is a separate issue from issue (1), and a fix that
fixes (2) is still a fix, and not a "workaround for issue (1)".

Btw. regarding issue (1), yeah, but see bug 439703. I noted the same issue (1)
but Halla closed it. There is a general idea that newly coming resources with
the same md5 should be disabled by default, and I guess maybe Halla focused on
that part when closing that bug report. I think the fact that this automatic
system makes *all* of the resources disabled, if the first one come from a
disabled bundle, might not exactly be expected or at least, I wouldn't expect
it as a user. But in any case, for that you'd need to talk with her.

--
Also about issue 2), you might need to also use:
resModel.setStorageFilter(KisResourceModel::ShowAllStorages)
to be sure to find the resource that comes from the disabled bundle as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to