https://bugs.kde.org/show_bug.cgi?id=443475
Jonathan Verner <jonathan.ver...@matfyz.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/kdev |https://invent.kde.org/kdev
|elop/kdevelop/commit/304907 |elop/kdevelop/commit/a99c31
|339df0f2185e29daacb411a0bed |2f4c7958f59d0ef41cb928f20f0
|1af6395 |dd44cfd
--- Comment #3 from Jonathan Verner <jonathan.ver...@matfyz.cz> ---
Git commit a99c312f4c7958f59d0ef41cb928f20f0dd44cfd by Jonathan L. Verner.
Committed on 11/11/2021 at 14:59.
Pushed by igorkushnir into branch 'release/21.12'.
Show an error message in the git commit view when committing fails
When committing fails, the user should be informed (and not expected to
notice this by seeing an error in the Version Control output view or knowing
commit message not being cleared means failure).
I opted to use a KMessageWidget instead of a Modal Dialog (per the HIG
guidelines,
although they are a bit unclear, since there is no clear action that the
user can take to remedy the situation).
I also opted for just a short message pointing the user to the Version Control
output view for more information due to the limited space available in the
commit toolview.
FIXED-IN: 5.7.0
M +3 -0 plugins/git/committoolview.cpp
M +22 -0 plugins/git/simplecommitform.cpp
M +19 -0 plugins/git/simplecommitform.h
https://invent.kde.org/kdevelop/kdevelop/commit/a99c312f4c7958f59d0ef41cb928f20f0dd44cfd
--
You are receiving this mail because:
You are watching all bug changes.
