https://bugs.kde.org/show_bug.cgi?id=443770
Jan Grulich <jgrul...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/plasma-nm/commit/a76f4d4 |ma/plasma-nm/commit/de0d415
|b0f75d1007d8fc13dc1e4c95c4a |56adf7f9976c8b7febeb2569aed
|66a430 |772d27
--- Comment #3 from Jan Grulich <jgrul...@redhat.com> ---
Git commit de0d41556adf7f9976c8b7febeb2569aed772d27 by Jan Grulich, on behalf
of Raphael Kubo da Costa.
Committed on 15/10/2021 at 10:07.
Pushed by grulich into branch 'cherry-pick-a76f4d4b'.
openconnect: Make FSID passphrase + empty private key combination work.
It should be possible to usen FSID-protected key passphrase with a user
certificate and no private key.
This was not working as expected because we were always calling
openconnect_set_client_cert() with QByteArray::data(). The latter will pass
an empty string rather than nullptr if it is empty, which can be the case
for `key` if it is not set. This causes openconnect_set_client_cert() to use
that empty string rather than handle the null argument case, and we would be
unexpectedly prompted for a key password when trying to connect.
Avoid running into this by explicitly passing `nullptr` when we have an
empty `key`.
(cherry picked from commit a76f4d4b0f75d1007d8fc13dc1e4c95c4a66a430)
M +1 -1 vpn/openconnect/openconnectauth.cpp
https://invent.kde.org/plasma/plasma-nm/commit/de0d41556adf7f9976c8b7febeb2569aed772d27
--
You are receiving this mail because:
You are watching all bug changes.
