https://bugs.kde.org/show_bug.cgi?id=442578
Eoin O'Neill <eoinoneill1...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/grap
| |hics/krita/commit/556e2bc3b
| |638acfadc463211ab2984466e43
| |a858
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Eoin O'Neill <eoinoneill1...@gmail.com> ---
Git commit 556e2bc3b638acfadc463211ab2984466e43a858 by Eoin O'Neill.
Committed on 12/10/2021 at 23:34.
Pushed by eoinoneill into branch 'master'.
Fix crash during animation export by simplifying RAII of ffmpeg subprocess.
We were manually cleaning up FFMPEG processes in some parts of the code
instead of relying on RAII, which caused some circumstances where the
process was freed while QProcess was invoking `waitForProcess`, which
seems to crash only on Windows systems. Qt must normally handle this
more gracefully on Linux, but can't do so on Windows.
We're now avoiding manual cleanup by making more use of QScopedPointer
and making our end of the code more clean. Now the process should simply
be cleaned up when FFMpegWrapper goes out of scope or is deleted,
which should avoid the pointer going null before it is supposed to.
M +3 -4 libs/ui/animation/KisDlgImportVideoAnimation.cpp
M +7 -11 libs/ui/animation/KisFFMpegWrapper.cpp
M +4 -2 libs/ui/animation/KisFFMpegWrapper.h
https://invent.kde.org/graphics/krita/commit/556e2bc3b638acfadc463211ab2984466e43a858
--
You are receiving this mail because:
You are watching all bug changes.
