https://bugs.kde.org/show_bug.cgi?id=443304
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/plas
| |ma/drkonqi/commit/6b68295f8
| |4804781dcd0de5cacbe3b6ce829
| |acd1
--- Comment #2 from Harald Sitter <sit...@kde.org> ---
Git commit 6b68295f84804781dcd0de5cacbe3b6ce829acd1 by Harald Sitter.
Committed on 08/10/2021 at 08:48.
Pushed by sitter into branch 'master'.
replace restart checkbox with button
for one, this aligns the UX a bit more between crash dialog and report
dialog (the former sports a button, not a checkbox, indeed I'm not sure
why one would want this to be a checkbox). it also removes a bug where
restart-on-finish would not run quick enough to finish before the
application exits, since restarting is an async option because we don't
know how long it really takes - instead of rearchitecturing how app exit
works so it can wait for the restart, it seems more reasonable to simply
have the restart action be a button and the user decide when they want
to stop waiting for the restart to happen. since the button kguititem is
now used in two dialogs it has moved to the globals stuff where there is
a new namespace that mimics KStandardGuiItem but for our guiitems.
visualization logic has also been simplified. with the restart action
now being a button with fairly generic text we can show it regardless of
context so long as the app hadn't been restarted.
M +1 -0 src/CMakeLists.txt
M +7 -19 src/bugzillaintegration/assistantpage_conclusion.cpp
M +7 -24 src/bugzillaintegration/ui/assistantpage_conclusions.ui
A +17 -0 src/drkonqi_globals.cpp [License: GPL(3+eV) GPL(v3.0)
GPL(v2.0)]
M +6 -1 src/drkonqi_globals.h
M +1 -6 src/drkonqidialog.cpp
https://invent.kde.org/plasma/drkonqi/commit/6b68295f84804781dcd0de5cacbe3b6ce829acd1
--
You are receiving this mail because:
You are watching all bug changes.
