https://bugs.kde.org/show_bug.cgi?id=433508

Mark Wielaard <m...@klomp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m...@klomp.org

--- Comment #3 from Mark Wielaard <m...@klomp.org> ---
Make sure to add launcher-freebsd.c in coregrind/Makefile.am (valgrind_SOURCES)
which was removed in commit f22758d6dad9bae9b7531046e42ce105f12e1ead

I didn't really review the 450K of new files. But they look plausible and are
nicely separated from the other platform code (things build and work fine on my
non-freebsd system). You might want to update the Copyright notices, while they
are clearly derived from the other existing code, it would be good to mention
the major copyright holders (I assume that is you and some of the people
mentioned in the credits of README.freebsd).

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to