https://bugs.kde.org/show_bug.cgi?id=443308
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
|hics/krita/commit/ab79babd4 |hics/krita/commit/0f12de8af
|7cb40a37a713eb9eef7f832167a |2493fe9a95fe5ced2d057d9f421
|f0a9 |6373
--- Comment #12 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 0f12de8af2493fe9a95fe5ced2d057d9f4216373 by Dmitry Kazakov.
Committed on 07/10/2021 at 09:25.
Pushed by dkazakov into branch 'krita/5.0'.
Fix crash when selecting text brush
The patch does several fixes:
1) Removes KoEphemeralResource CRTP class and replaces it with two virtual
functions in KoResource: isEphemeral() and isSerializable() to distincs
between the two mixed uses of KoEphemeralResource. Non-serializable
resource is the one that has no load/save() methods. Ephemeral resource
is non-serializable, but also has no md5sum, therefore cannot be stored
in the resources database.
The main disadvantage of CRTP pattern is that IDE cannot parse such
hierarchies, that is, such classes are not included into Ctrl+Shift+T
report.
2) Removes `requiredBrushFilesList` .kpp tag that was used for the masking
brushes in Krita 4.x. Modern Krita can fetch such list itself using
KoResource::requiredResources().
M +21 -3 libs/brush/kis_abr_brush.cpp
M +5 -2 libs/brush/kis_abr_brush.h
M +20 -2 libs/brush/kis_auto_brush.cpp
M +5 -2 libs/brush/kis_auto_brush.h
M +18 -1 libs/brush/kis_text_brush.cpp
M +4 -3 libs/brush/kis_text_brush.h
M +0 -5 libs/image/brushengine/KisPaintopSettingsIds.cpp
M +0 -4 libs/image/brushengine/KisPaintopSettingsIds.h
M +7 -16 libs/image/brushengine/kis_paintop_preset.cpp
M +0 -1 libs/image/kis_gradient_painter.cc
M +20 -2 libs/image/kis_psd_layer_style.cpp
M +5 -2 libs/image/kis_psd_layer_style.h
D +0 -54 libs/resources/KoEphemeralResource.h
M +14 -0 libs/resources/KoResource.cpp
M +26 -0 libs/resources/KoResource.h
M +0 -18 plugins/paintops/libpaintop/KisMaskingBrushOptionProperties.cpp
M +1 -24 plugins/paintops/libpaintop/kis_brush_option.cpp
https://invent.kde.org/graphics/krita/commit/0f12de8af2493fe9a95fe5ced2d057d9f4216373
--
You are receiving this mail because:
You are watching all bug changes.
