https://bugs.kde.org/show_bug.cgi?id=433506

Mark Wielaard <m...@klomp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m...@klomp.org

--- Comment #2 from Mark Wielaard <m...@klomp.org> ---
This patch makes cachegrind/tests/Makefile.am executable, which I think is
wrong.
The actual change looks fine though. As does the change to callgrind/main.c.

In dhat/tests/copy.c, which test for && defined(__GNUC__)?
Is mempcpy defined if __GNUC__ isn't on freebsd?

In none/tests/Makefile.am is it deliberate that resolv doesn't get any LDADD
flags anymore (asking because res_search still does).

In none/tests/amd64/Makefile.am why is the dependency on
$(srcdir)/gen_insn_test.pl removed for the .def.c target?

none/tests/amd64/faultstatus.c changes the type of escape from jmp_buf to
sigjmp_buf. This looks correct. I am just surprised this worked before.

The none/tests/amd64/insn_ssse3.vgtest prereq change is ok too.
This probably also should always have been this way.

It is somewhat unfortunate we need
none/tests/amd64/sse4-64.stdout.exp-freebsd-clang and
none/tests/amd64/sse4-64.stdout.exp.freebsd, they are huge.

The ssse3_misaligned look correct.

There are a lot of extra none/tests/fdleak*exp.freebsd. It looks like freebsd
doesn't provide the name of the file behind an fd. Is this a bug in the file
descriptor leak checker on freebsd?

Assuming everything under none/tests/freebsd is fine.

I don't understand the none/tests/x86/gen_insn_test.pl change.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to