https://bugs.kde.org/show_bug.cgi?id=433439

--- Comment #4 from Paul Floyd <pjfl...@wanadoo.fr> ---
Why do you think making sysctl newp const might be unsafe?

The signature on FreeBSD is

     int
     sysctl(const int *name, u_int namelen, void *oldp, size_t *oldlenp,
         const void *newp, size_t newlen);

On Darwin it is non--const, but there are only two calls to it both with NULL
arguments for newp.

Either way newp gets cast to (UWord).

I prefer to keep it const as this makes the interface clearer (an optional
input-only argument).


I've removed the include of vki/vki-scnums-freebsd.h in
include/pub_tool_vkiscnums.h. It does no longer seem necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to