https://bugs.kde.org/show_bug.cgi?id=442481

Eugene Shalygin <eugene.shalygin+bugzilla....@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|NEEDSINFO                   |CONFIRMED
         Resolution|WORKSFORME                  |---

--- Comment #2 from Eugene Shalygin <eugene.shalygin+bugzilla....@gmail.com> ---
Thank you for looking into this!

So, I've got Gentoo and zsh here. The kdevplatform_shell_environment.sh
absolutely does not work in this environment.

1. My $ZDOTDIR is empty: it fails to detect zsh. Why not simply check $SHELL?
E.g. _shell=$(basename "$SHELL"). I guess those who rename their shell
executables know that they are doing.

2. This "$(which $_qdbus 2> /dev/null)" executes result of "which $_qdbus", so
when it is negated, $_qdbus value is not changed when there is no qdbus-qt5
executable. A proper test is:

if ! command -v $_qdbus &> /dev/null; then
    _qdbus=qdbus
    if ! command -v $_qdbus &> /dev/null; then
        echo "The utility qdbus (or qdbus-qt5) is not in your path, the shell
integration will not work properly."
    fi
fi

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to