https://bugs.kde.org/show_bug.cgi?id=442333
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/plas
| |ma/drkonqi/commit/2f6a3ad22
| |b092a511377b6ae1cb29535be77
| |bd06
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #2 from Harald Sitter <sit...@kde.org> ---
Git commit 2f6a3ad22b092a511377b6ae1cb29535be77bd06 by Harald Sitter.
Committed on 13/09/2021 at 16:16.
Pushed by sitter into branch 'master'.
repair the distro selection
this actually broke before 5.21 even but nobody would ever notice
because in absence of a value we had internal fallbacks in place to
ensure a platform is selected. what apparently happend was that until
the recent paging refactor the distro combobox was always hidden by the
time abouttohide ran and so the entire code path was effectively skipped
meaning the distro selection as a whole was kaput (I've reproduced as
much). with the recent refactor the code path became working again and
fell into a trap that had been there for a while:
we actually place the field values in the combobox as text not data, so
what would happen here is that we'd get an invalid qvariant for data,
resulting in an empty string, resulting in an invalid bug POST to the
API, resulting in the API rejecting the submission.
simply use the text instead.
side effect of this fix is that distro selection works again :shrug:
an argument might be made that this combobox as a whole is fairly
useless. if we add a new product to bugzilla we should also add it to
drkonqi and if we didn't then the combobox won't help anyway as the
majority of reporters surely won't pay attention or can't be bothered to
find the right platform in this huge list of stuff
(make the line const correct while at it)
M +1 -1 src/bugzillaintegration/reportassistantpages_bugzilla.cpp
https://invent.kde.org/plasma/drkonqi/commit/2f6a3ad22b092a511377b6ae1cb29535be77bd06
--
You are receiving this mail because:
You are watching all bug changes.
