https://bugs.kde.org/show_bug.cgi?id=441803

Ahmad Samir <a.samir...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/-/commit/5ab8
                   |                            |423139467ad97d87d00dc82a85f
                   |                            |91c5a1492
         Resolution|---                         |FIXED
                 CC|                            |a.samir...@gmail.com
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |21.08

--- Comment #2 from Ahmad Samir <a.samir...@gmail.com> ---
I think this issue is fixed in
https://invent.kde.org/utilities/konsole/-/commit/5ab8423139467ad97d87d00dc82a85f91c5a1492
, version 21.08

Basically when you use "Edit current profile" for the first time, you'd be
editing the built-in profile, which is immutable, so the dialog actually
creates a new profile (as you saw), the missing bit was setting that new
profile as the current session profile:
SessionManager::instance()->setSessionProfile(session(), profile);

FWIW, in git master the menu text has been changed, if the dialog will create a
new profile the text is "create new profile", if it's editing an existing
(editable) profile, it is "edit current profile".

And there is an open MR to rename the "Default" (aka Fallback, aka Built-in)
profile to "Built-in" everywhere, to finally disambiguate the name of the
internal immutable profile.

(A "set profile as default" button sounds like a good idea, currently the only
way to set a profile as default is using the profile manager (settings ->
configure konsole)).

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to