https://bugs.kde.org/show_bug.cgi?id=409620

--- Comment #7 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit c193efc96239f1a0611206708b84dba2d7befdaa by David Edmundson, on
behalf of Tatsuyuki Ishi.
Committed on 01/09/2021 at 21:42.
Pushed by davidedmundson into branch 'master'.

blur: add noise in perceptual space

The previous implementation added noise in linear space, which resulted in
the effect becoming more pronounced on black backgrounds. This patch
changes the process to be applied in perceptual space, by making the noise
addition pass a separate draw call and disabling GL_FRAMEBUFFER_SRGB during
that.

After this change, noise will look much more suppressed and almost never
grainy. This change also changes the range of the noise from
[-strength..strength) to [0..strength), as blending can only be either
additive or subtractive. As a result, users might need to ramp up their
noise parameter after this change.

v2: Add more explanation around the draw call.
v3: Fix noise not fading out with the fade out effect.
v4: Restore an accidentally removed comment.
v5: Add CCBUG.
v6: Rebase.
v7: Fix a formatting issue.

M  +39   -15   src/effects/blur/blur.cpp
M  +1    -0    src/effects/blur/blur.h
M  +5    -20   src/effects/blur/blurshader.cpp

https://invent.kde.org/plasma/kwin/commit/c193efc96239f1a0611206708b84dba2d7befdaa

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to