https://bugs.kde.org/show_bug.cgi?id=381794
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/fram
| |eworks/plasma-framework/com
| |mit/4edb830f53aac4833ece024
| |df59441029b01fde6
Version Fixed In| |5.85
--- Comment #17 from Nate Graham <n...@kde.org> ---
Git commit 4edb830f53aac4833ece024df59441029b01fde6 by Nate Graham.
Committed on 28/07/2021 at 15:40.
Pushed by ngraham into branch 'master'.
Fix Units::roundToIconSize() returning incorrect sizes with non-Qt scaling
When not using Qt Scaling (testable by using the Wayland session or
setting `PLASMA_USE_QT_SCALING=1` on X11), all pixel sizes are unscaled.
E.g. a 22x22 SmallMedium icon must be expressed as 44x44 to Plasma,
because it is not aware of Qt's scaling.
The `Units::roundToIconSize()` function was failing to do this, thus
returning incorrectly small icon sizes. For example you would ask it
for the correct icon for a 44px physical area, expecting a SmallMedium
icon--but internally the function would would find that 44 is lower than
48 (unscaled Large size), and give you the next smallest size, which
is Medium. Unscaled Medium is 32px, which is equivalent to a 16px scaled
icon. So you would get a Small icon when you expected a SmallMedium one.
Due to quirks of how the icon sizes increase at the larger end, correct
results were accidentally returned for larger icon sizes. However small
and smallMedium icons were always incorrectly getting the next smallest
size instead, most commonly manifesting as ToolButtons and System Tray
icons being too small.
This commit fixes the problem by scaling all of the icon sizes
internally both for the purposes of comparison and returning a final
value--but only when not using Qt scaling.
Related: bug 390147
FIXED-IN: 5.85
M +41 -27 src/declarativeimports/core/units.cpp
M +8 -0 src/declarativeimports/core/units.h
https://invent.kde.org/frameworks/plasma-framework/commit/4edb830f53aac4833ece024df59441029b01fde6
--
You are receiving this mail because:
You are watching all bug changes.
