https://bugs.kde.org/show_bug.cgi?id=439676

michael <reeves...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.9.3
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/sdk/
                   |                            |kdiff3/commit/a0fad8add09df
                   |                            |00f722c97506d7f73b483d60464
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from michael <reeves...@gmail.com> ---
Git commit a0fad8add09df00f722c97506d7f73b483d60464 by Michael Reeves.
Committed on 10/07/2021 at 21:28.
Pushed by mreeves into branch 'master'.

Move DirectoryInfo to global scope.

This makes the code cleaner and less confusing we only need one DirectoryInfo.
Keep shared pointer status for now maybe reviewed later but is out of scope.
KDiff3 has multiple code paths for starting a compare so the old intialization
did not cover all cases.
Move this first time setup to the default iniialization.
This is safe for most code. Constuctors for other global/static variables
however can not depend on this having taken place.
FIXED-IN:1.9.3

M  +3    -0    src/DirectoryInfo.cpp
M  +2    -0    src/DirectoryInfo.h
M  +6    -8    src/MergeFileInfos.cpp
M  +1    -4    src/MergeFileInfos.h
M  +0    -2    src/kdiff3.h
M  +5    -11   src/pdiff.cpp

https://invent.kde.org/sdk/kdiff3/commit/a0fad8add09df00f722c97506d7f73b483d60464

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to