https://bugs.kde.org/show_bug.cgi?id=438038
--- Comment #5 from ahashmi <assad.has...@linaro.org> ---
(In reply to Julian Seward from comment #3)
> No .. ensure SIGILL is raised (decode failure) for any undecodable insns.
> Never assert.
Good point, I've changed it to:
+ else {
+ /* ty = 2 is an illegal encoding */
+ if (sigill_diag) {
+ vex_printf("ARM64 front end: dis_AdvSIMD_fp_conditional_compare\n");
+ }
+ return False;
+ }
> + return True;
>
> return False;
>
> This is a strange sequence. The second return is unreachable. (Maybe I
> misread?)
My bad. The second return is a leftover from some debug testing which I should
have deleted.
> As a nit, in such situations I'd prefer if you set these both to NULL so as to
> protect against future snafus .. I know it's redundant as the code stands.
> Viz:
>
> HReg (*iselExpr)(ISelEnv*, IRExpr*) = NULL;
> ARM64Instr* (*VCmp)(HReg, HReg) = NULL
Good point! initialised.
Bugs caused by uninitialised data can be insidious. The code is fine now but
possible future changes in the subsequent if clauses could allow such bugs to
appear.
--
You are receiving this mail because:
You are watching all bug changes.
