https://bugs.kde.org/show_bug.cgi?id=374538
--- Comment #38 from imagina...@mailbox.org ---
Re-testet the last step with more load and time and it was indeed a false
negative, logout failed.
Assuming (!) that otherwise all "goods" were correct the final result then
would be:
3c34dfa97f3ed5ba1c28a02e85c4de73877469fb is the first bad commit
commit 3c34dfa97f3ed5ba1c28a02e85c4de73877469fb
Author: David Edmundson <k...@davidedmundson.co.uk>
Date: Mon Mar 2 13:05:35 2020 +0000
[plasma-session] Load startup and shutdown on demand
Summary:
Currently startplasma spawns plasma-session then sits around waiting for
that to finish
plasma-session spawns all the startup then also just sits around doing
nothing
This patch makes plasma-session spawn all the startup and then quit.
It also splits the owner of the org.kde.shutdown interface to be on
demand. plasma-shutdown asks ksmserver to quit and then if applicable
runs the shutdown scripts or not.
Startplasma then knows when to exit by monitoring the DBus service
status directly.
The benefits are that we save some resources by not needing
plasma-session lingering about.
It also means the shutdown interface is re-usable as-is when the pending
systemd startup method is used.
Test Plan:
Logged in and:
- ran killall ksmserver, session ended as before
- logged out and cancelled due to unsaved changes
- logged out and completed logout
- logged out and rebooted
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27629
ksmserver/CMakeLists.txt | 2 +-
libkworkspace/CMakeLists.txt | 2 +-
startkde/CMakeLists.txt | 1 +
startkde/plasma-session/CMakeLists.txt | 3 -
startkde/plasma-session/main.cpp | 3 -
startkde/plasma-session/org.kde.Shutdown.xml | 8 ---
startkde/plasma-session/shutdown.cpp | 97 --------------------------
startkde/plasma-session/shutdown.h | 45 ------------
startkde/plasma-session/startup.cpp | 1 +
startkde/plasma-shutdown/CMakeLists.txt | 23 +++++++
startkde/plasma-shutdown/main.cpp | 28 ++++++++
startkde/plasma-shutdown/org.kde.Shutdown.xml | 8 +++
startkde/plasma-shutdown/shutdown.cpp | 99 +++++++++++++++++++++++++++
startkde/plasma-shutdown/shutdown.h | 45 ++++++++++++
startkde/startplasma-wayland.cpp | 1 +
startkde/startplasma-x11.cpp | 4 +-
startkde/startplasma.cpp | 45 ++++++++++--
17 files changed, 249 insertions(+), 166 deletions(-)
delete mode 100644 startkde/plasma-session/org.kde.Shutdown.xml
delete mode 100644 startkde/plasma-session/shutdown.cpp
delete mode 100644 startkde/plasma-session/shutdown.h
create mode 100644 startkde/plasma-shutdown/CMakeLists.txt
create mode 100644 startkde/plasma-shutdown/main.cpp
create mode 100644 startkde/plasma-shutdown/org.kde.Shutdown.xml
create mode 100644 startkde/plasma-shutdown/shutdown.cpp
create mode 100644 startkde/plasma-shutdown/shutdown.h
At first glance this makes more sense than the one reported previously. When I
find time I'll re-test the other "goods".
--
You are receiving this mail because:
You are watching all bug changes.
