https://bugs.kde.org/show_bug.cgi?id=435908

--- Comment #6 from Aaron Merey <ame...@redhat.com> ---
(In reply to Tom Hughes from comment #4)
> No that patch won't help.
> 
> The debugname variable is just the name of the file to look for and is in
> fact pretty much always set.
> 
> If .gnu_debuglink was present then crc would be set but modern systems don't
> use that anyway - they use .note.gnu.build-id instead and that is always set
> even if debug hasn't been separated out.

debugname is set when a .gnu_debuglink or .gnu_debugaltlink section is present
and is NULL when there is a build-id but no .gnu_debuglink. It is the latter
case in which debuginfod is unnecessary since there is no separate debug file
to be found. So I don't see how my patch fails to stop unnecessary debuginfod
calls.

Regardless your patch is better insofar as it avoids calling find_debug_file
altogether for unstripped binaries instead of just skipping
find_debug_file_debuginfod.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to