https://bugs.kde.org/show_bug.cgi?id=435309
Duncan <1i5t5.dun...@cox.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Ever confirmed|0 |1
Status|RESOLVED |REOPENED
--- Comment #16 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Duncan from comment #7)
> (In reply to Ahmad Samir from comment #6)
> > Should be fixed by
> > https://invent.kde.org/utilities/konsole/-/merge_requests/380
> Works for me! =:^)
Just upgraded to gcc-11.1.0 (from 10.3.0) and it no-longer works. =:^( See
below.
(In reply to Paulo from comment #15)
> (In reply to Antonio Rojas from comment #12)
> > With some color schemes - such as Dark Pastels - this patch doesn't make any
> > difference. The selection is still hard to see.
> +1
>
> Instead of trying to fix the new behavior, can we get the old one? Reverse
> video for highlighted text was working and everyone was used to it.
While the new colors (if not the code) still works for me, given the facts that
it's not working for everyone, that a revert to the old reversing behavior
would be find by me as well, and that all the related bugs are now duped to
this one, I'll go ahead and reopen this to report the new code error rather
than opening a new bug as I normally would since the aspect I personally am
experiencing arguably /is/ a new bug.
FWIW I'll update the invent thread with the new gcc-11.1.0 error as well.
Again, this error is what I'm getting on the new gcc-11.1.0 I just installed,
while switching back to 10.3.0 to double-check verifies 10.3.0 is still
building the code without error:
FAILED: src/CMakeFiles/konsoleprivate.dir/terminalDisplay/TerminalPainter.cpp.o
[snip the big long commandline]
../konsole-9999/src/terminalDisplay/TerminalPainter.cpp:381:10: error:
'optional' in namespace 'std' does not name a template type
381 | std::optional<QColor> calculateBackgroundColor(const Character*
style, const QColor *colorTable)
| ^~~~~~~~
../konsole-9999/src/terminalDisplay/TerminalPainter.cpp:32:1: note:
'std::optional' is defined in header '<optional>'; did you forget to '#include
<optional>'?
31 | #include <QtMath>
+++ |+#include <optional>
32 |
../konsole-9999/src/terminalDisplay/TerminalPainter.cpp: In member function
'void Konsole::TerminalPainter::drawTextFragment(QPainter&, const QRect&, const
QString&, const Konsole::Character*, const QColor*, Konsole::LineProperty)':
../konsole-9999/src/terminalDisplay/TerminalPainter.cpp:413:40: error:
'calculateBackgroundColor' was not declared in this scope
413 | const QColor backgroundColor = calculateBackgroundColor(style,
colorTable).value_or(foregroundColor);
| ^~~~~~~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.
FWIW reverting to 7c5f08a2e, immediately before the 3b0 commit that killed
reverse-select, builds (and runs) with gcc-11.1.0 too. There's enough commits
stacked on top of the target reversion commit now that it's getting a bit more
complex to revert the individual commits (at least for a quick test), but
reverting to that commit as head still works even if it's losing some other
work by now as well.
--
You are receiving this mail because:
You are watching all bug changes.
