https://bugs.kde.org/show_bug.cgi?id=435699

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.22.0
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-disks/commit/b191
                   |                            |4d5a1c6cf0ae957e1b07aec9f3c
                   |                            |153ed6e2e
         Resolution|---                         |FIXED

--- Comment #8 from Harald Sitter <sit...@kde.org> ---
Git commit b1914d5a1c6cf0ae957e1b07aec9f3c153ed6e2e by Harald Sitter.
Committed on 15/04/2021 at 13:08.
Pushed by sitter into branch 'master'.

consider devices invalid (ignore them) that have smart disabled

when SMART is disabled smartctl will exit0 but contain no smart_status
which means default values get used and the device is considered
invalid. since we don't know what the status is in this situation we'll
consider the entire data set invalid and thereby hide the device.

with the growing amount of potentially discarded (but present) data
blobs it might soon make sense to think about rendering invalid devices
in the KCM with an unknown state so people at least can find out that
their drives aren't being monitored
FIXED-IN: 5.22.0

A  +77   -0    autotests/fixtures/pass-without-status.json
A  +2    -0    autotests/fixtures/pass-without-status.json.license
M  +1    -0    autotests/fixtures/simulation.qrc
M  +15   -0    autotests/smartdatatest.cpp
M  +9    -0    src/smartdata.cpp

https://invent.kde.org/plasma/plasma-disks/commit/b1914d5a1c6cf0ae957e1b07aec9f3c153ed6e2e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to