https://bugs.kde.org/show_bug.cgi?id=432754
Halla Rempt <ha...@valdyas.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/grap
| |hics/krita/commit/0a9b43e3c
| |868dff731f5168596563d9d897b
| |15fe
Resolution|--- |FIXED
--- Comment #4 from Halla Rempt <ha...@valdyas.org> ---
Git commit 0a9b43e3c868dff731f5168596563d9d897b15fe by Halla Rempt, on behalf
of Agata Cacko.
Committed on 30/03/2021 at 08:36.
Pushed by rempt into branch 'master'.
Fx MyPaint brush engine crashing in big sizes
Before this commit, MyPaint brushes would crash on big sizes
(easy test: size 1000px on blend+paint) because it was
initialized in the stack instead of on the heap.
(For future readers, the wrong/stack initialization for big sizes:
int array[size];
heap initialization:
int array = new array[size]; // and remember to delete [] array;!)
This commit not only removes that initialization which fixes the crash,
but also changes it to use a fixed device instead, which should
help with memory fragmentization and make the brush engine
faster on Windows (hopefully - no benchmarks were done).
M +12 -4 plugins/paintops/mypaint/MyPaintSurface.cpp
M +2 -0 plugins/paintops/mypaint/MyPaintSurface.h
https://invent.kde.org/graphics/krita/commit/0a9b43e3c868dff731f5168596563d9d897b15fe
--
You are receiving this mail because:
You are watching all bug changes.
