https://bugs.kde.org/show_bug.cgi?id=434451
--- Comment #15 from Christoph Cullmann <cullm...@kde.org> --- (In reply to Luke Horwell from comment #13) > Thanks, I rebuilt the branch again and apps are back to normal. > > Regarding git-cola, I have no code hints. After setting "Icon Theme" via the > preferences window, the program just needs to be restarted to see the new > icon scheme. Ok, thanks anyways for pointing out the extra issues. > > > See > > https://kate-editor.org/post/2021/2021-03-07-cross-platform-light-dark-themes-and-icons/ > > for the reason. > > IMO, the "kiconthemes" package shouldn't risk inconsistencies or create > unintended bugs for non-KDE Qt-based apps. I think it would be a better > practice for QIconEngine not to be overridden by KIconEngine when this > package is installed. If it can specifically be confined to KDE applications > or be overridden by some other condition, like an environment variable, that > would be better. The problem is, there is no good interface for this (at least nobody found one yet) that allows to have for KDE stuff the auto-coloring but not touching such global things. Inside a KDE Plasma session, another plugin will ensure the KIconEngine is used (that will affect non-KDE applications there, too), but that won't help outside of a KDE Plasma session. In any case, you are totally right, if the change is not 1:1 transparent for applications not using the "advanced" features, it is not acceptable, either our replacement works 1:1 like the QSvgIconEngine for other Qt stuff, or we shall not do this. I am sorry that you had these issues, it was not clear from testing that our icon loader behaves differently from the Qt one (beside additional features Qt applications won't be able to use anyways). -- You are receiving this mail because: You are watching all bug changes.
