https://bugs.kde.org/show_bug.cgi?id=421136
--- Comment #19 from Alvin Wong <al...@alvinhc.com> ---
(In reply to Halla Rempt from comment #7)
> I don't have access this hardware, but could you please this patch?
>
> diff --git a/libs/ui/CMakeLists.txt b/libs/ui/CMakeLists.txt
> index 1dd227e432..25db539747 100644
> --- a/libs/ui/CMakeLists.txt
> +++ b/libs/ui/CMakeLists.txt
> @@ -7,7 +7,8 @@ include_directories(SYSTEM
> ${OCIO_INCLUDE_DIR}
> )
>
> -if (ANDROID)
> +# This is going to break when we start building on Windows ARM...
> +if (ANDROID OR (CMAKE_SYSTEM_PROCESSOR MATCHES
> "^(aarch64.*|AARCH64.*|arm64.*|ARM64.*)" AND NOT APPLE))
> add_definitions(-DQT_OPENGL_ES_3)
> add_definitions(-DHAS_ONLY_OPENGL_ES)
> include_directories (${Qt5AndroidExtras_INCLUDE_DIRS})
I want to say this patch is not exactly correct. This assumes any Linux ARM
systems can only use OpenGL ES, but it is in fact possible to build Qt to use
desktop OpenGL on ARM/AArch64. AFAICT Debian on AArch64 provides system Qt
packages configured with desktop OpenGL.
I think there should be ways to determine from Qt's defines whether it is built
with desktop OpenGL or OpenGL ES support, instead of guessing based on OS and
CPU architecture.
--
You are receiving this mail because:
You are watching all bug changes.
