https://bugs.kde.org/show_bug.cgi?id=292935

--- Comment #6 from Jonathan Wakely <zi...@kayari.org> ---
(In reply to Andrew Udvare from comment #2)
> Maybe arkrc can have a section for meta data files to ignore so advanced
> users can edit the list without having to modify Ark's source.
> 
> [IgnoreExactMatch]
> Thumbs.db
> .DS_Store
> __MACOSX
> .directory

That customization feature might be nice, but might cause issues for people who
don't realize the feature exists and don't know where to make the
customization.

I think having the feature off by default is probably safest, but there could
be a global configuration to turn it on, and the "Extract" dialog could show a
checkbox for it with the other Options, to allow it to be turned on for
individual extract operations (rather than globally).

If it's easily turned on/off it's probably sufficient to just ignore __MACOSX
and .DS_Store folders at the top level of the archive. If they occur below the
top level, they might be there intentionally (if they'd been created
automatically on MacOS then they'd also be present at the top level).

> This also means Ark would never have to actually test the contents of these
> files/directories should one appear in an archive that isn't actually what
> these normally are (especially since Thumbs.db could definitely mean a
> thumbnail database to something completely different).

If it's easily enabled/disabled in the Extract dialog I think testing the
contents of the metadata dirs probably isn't necessary. If extra checks are
desirable though, I suggest the heuristic should be that a folder called
__MACOSX or .DS_Store is not extracted if everything below it is either a
folder, or an AppleDouble file (i.e. one beginning with "._"). I don't think
it's necessary to verify that there's a one-to-one mapping from those
AppleDouble files to the actual files elsewhere in the archive. If somebody
wants to extract them, they can just uncheck the "Ignore metadata junk" option.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to