https://bugs.kde.org/show_bug.cgi?id=429804
Harald Sitter <sit...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Latest Commit| |https://invent.kde.org/plas | |ma/plasma-disks/commit/3d10 | |fed37315a7dd7bcee66797b74ec | |e615a2217 Resolution|--- |FIXED --- Comment #10 from Harald Sitter <sit...@kde.org> --- Git commit 3d10fed37315a7dd7bcee66797b74ece615a2217 by Harald Sitter. Committed on 09/03/2021 at 12:14. Pushed by sitter into branch 'master'. report smartctl failure codes to the user as it turns out there are a number of issues that do not result in an actually bad SMART status and would not get reported to the user. to keep the code lean we'll simply look at the exit code bits of smartctl as they more or less cover all failure scenarios anyway. we'll then translate those to pretty strings and expose them on the Device objects for consumption in the qml KCM as "instabilities". they are set visually apart from actual bad status through different icon and description because it's hard to say if an instability is in fact indicative of imminent hard-failure or merely a hiccup (e.g. power loss during a disk operation). FIXED-in: 5.22 M +22 -1 autotests/smartdatatest.cpp M +2 -0 src/CMakeLists.txt M +15 -1 src/device.cpp M +14 -1 src/device.h A +60 -0 src/instabilities.cpp [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] A +15 -0 src/instabilities.h [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] M +34 -11 src/kcm/package/contents/main.qml M +3 -2 src/smartctl.cpp M +0 -28 src/smartctl.h M +12 -2 src/smartdata.cpp M +19 -1 src/smartdata.h A +4 -0 src/smartfailure.cpp [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] A +43 -0 src/smartfailure.h [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] M +3 -2 src/smartmonitor.cpp M +17 -6 src/smartnotifier.cpp https://invent.kde.org/plasma/plasma-disks/commit/3d10fed37315a7dd7bcee66797b74ece615a2217 -- You are receiving this mail because: You are watching all bug changes.