https://bugs.kde.org/show_bug.cgi?id=433064

Arjen Hiemstra <ahiems...@heimr.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/libksysguard/commit/10d8
                   |                            |d20a3bc4016ee271aee234f7727
                   |                            |e5640cedc
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Arjen Hiemstra <ahiems...@heimr.nl> ---
Git commit 10d8d20a3bc4016ee271aee234f7727e5640cedc by Arjen Hiemstra.
Committed on 01/03/2021 at 12:18.
Pushed by ahiemstra into branch 'master'.

Properly fix column count and inserting new columns on metadata load

Commit 74db33b1 tried to fix this but did this through always creating
an instance of SensorInfo. This means we never end up inserting new data
in onMetaDataChanged, which breaks the "ready" state of the model and
can lead to an invalid value being produced for the "UpdateInterval"
model role, which means we end up with incorrect chart update rates.

We now use sensorInfos for determining column count and whether or not
the model is ready, which should better reflect the state of the model.

M  +2    -6    sensors/SensorDataModel.cpp

https://invent.kde.org/plasma/libksysguard/commit/10d8d20a3bc4016ee271aee234f7727e5640cedc

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to