https://bugs.kde.org/show_bug.cgi?id=362805
Maximiliano Curia <m...@debian.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m...@debian.org
--- Comment #17 from Maximiliano Curia <m...@debian.org> ---
With the addtion of the test case in:
https://quickgit.kde.org/?p=kwallet.git&a=commitdiff&h=7e7644b608e22a13e110284ed6c5426c1b493b43
It's clear now that the blowfish backend doesn't work in big endian, as shown
in the buildds logs for mips and powerpc in Debian:
https://buildd.debian.org/status/package.php?p=kwallet-kf5
Adding back the include:
#include <QtCore/qglobal.h>
and changing the checks for #if Q_BYTE_ORDER == Q_LITTLE_ENDIAN
(effectively reverting the blowfish backend to the state in
https://quickgit.kde.org/?p=kwallet.git&a=blob&h=e09d5422dfb404f2f15e74d693b24bb6cd8e1689&hb=87e774825b779ba846315a8b2ffe6479dd9f9814&f=src%2Fruntime%2Fkwalletd%2Fbackend%2Fblowfish.cc)
makes the test pass in little and big endian machines.
This changes nothing for little endian machines. And in big endian machines it
should fix the blowfish backend.
Happy hacking,
--
You are receiving this mail because:
You are watching all bug changes.
