https://bugs.kde.org/show_bug.cgi?id=412596
Kurt Hindenburg <kurt.hindenb...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REPORTED |RESOLVED
Version Fixed In| |20.12
Latest Commit| |https://invent.kde.org/util
| |ities/konsole/commit/c33eba
| |8c60b99d00cd73c400d23b6f338
| |ef32a85
Resolution|--- |FIXED
--- Comment #12 from Kurt Hindenburg <kurt.hindenb...@gmail.com> ---
Git commit c33eba8c60b99d00cd73c400d23b6f338ef32a85 by Kurt Hindenburg, on
behalf of Carlos Alves.
Committed on 02/11/2020 at 18:14.
Pushed by hindenburg into branch 'master'.
Fix konsole crashes when rearranging split views
I'll try to explain here what I saw in this bug.
Following the BUG instructions, drag the terminal[2] and drop
(here the "drop event" starts)
-> the dragged terminal "ViewSplitter" become scheduled for deletion,
but it will only happens when it is in event loop.
-> And of course it is not in event loop yet, it is still the
"drop event" and it call the "addTerminalDisplay" to add the dragged
terminal to a "ViewSplitter".
-> This makes count() counts this scheduled for deletion "ViewSplitter"
and goes to the wrong "if".
-> It adds the "ViewSplitter" with the terminals into a
"marked for deletion" one, finishes the "drop event" and enters
event loop (a crash without a memleak! everything in the tab
is properly deleted).
Related: bug 411741
FIXED-IN: 20.12
M +4 -0 src/widgets/ViewSplitter.cpp
https://invent.kde.org/utilities/konsole/commit/c33eba8c60b99d00cd73c400d23b6f338ef32a85
--
You are receiving this mail because:
You are watching all bug changes.
