https://bugs.kde.org/show_bug.cgi?id=428332
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
|hics/krita/commit/84ed943ed |hics/krita/commit/17546d3ae
|0c722b76cb8181870a3b6ff0442 |4afa732b0ecc48ade59c0c8417b
|0fdc |128b
--- Comment #5 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 17546d3ae4afa732b0ecc48ade59c0c8417b128b by Dmitry Kazakov.
Committed on 27/10/2020 at 21:10.
Pushed by dkazakov into branch 'krita/4.4.0'.
Fix loading masks with vector selections
Loading has become broken after commit from June 2020:
6f283ca981 Fix undo breakage after converting a pixel selecion into a vector
one
After this change, when a selection is converted into a vector form,
the content of the pixel selection becomes discarded (due to a separate
undo history). Theoreticalll, the projection should become updated using
KisUpdateSelectionJob, but it happens too lately (because the image is
locked while loading). More than that, this job doesn't cause a setDirty()
for the parental node. It happens because we don't usually expect vector
selections to be edited on anything other than selection masks (it is just
not possible for anything other than selection masks).
This patch fixes the issue by calling selection->updateProjection()
explicitly. That is not ideal, because it makes the projection
recalculated twice, but it doesn't seem to be too critical.
The patch also skips loading pixel selection at all, if any vector
selection is present. There is no need for it anymore.
M +32 -10 plugins/impex/libkra/kis_kra_load_visitor.cpp
https://invent.kde.org/graphics/krita/commit/17546d3ae4afa732b0ecc48ade59c0c8417b128b
--
You are receiving this mail because:
You are watching all bug changes.
