https://bugs.kde.org/show_bug.cgi?id=364381
Bug ID: 364381 Summary: sftp/kio_sftp.cpp:1249]: (style) Suspicious condition Product: kio-extras Version: 5.6.5 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: default Assignee: plasma-de...@kde.org Reporter: dcb...@hotmail.com kio-extras-16.04.2/sftp/kio_sftp.cpp:1249]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is } else if ((errorCode = writeToFile(fd, filedata.constData(), filedata.size()) != 0)) { Maybe better code } else if ((errorCode = writeToFile(fd, filedata.constData(), filedata.size())) != 0) { Reproducible: Always -- You are receiving this mail because: You are watching all bug changes.