https://bugs.kde.org/show_bug.cgi?id=426645
Eike Hein <h...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/plas
| |ma/plasma-workspace/commit/
| |fcdbbda3965d73900c415071ad8
| |82f550994fdc2
Resolution|--- |FIXED
--- Comment #6 from Eike Hein <h...@kde.org> ---
Git commit fcdbbda3965d73900c415071ad882f550994fdc2 by Eike Hein.
Committed on 07/10/2020 at 18:37.
Pushed by hein into branch 'master'.
[kicker] Don't add invalid actions to the system action model
The system actions model recently changed behavior to always present all
possible actions, with `AbstractEntry::isValid` driving the model role
`Kicker::DisabledRole` so that views can e.g. grey out unavailable
actions.
This was perceived as a regression by users who are annoyed at e.g.
`Hibernate` being visible when their system setup precludes it more or
less permanently.
This patch reverts this behavior.
Note that the dynamic approach we had permanently wasn't very great
anyway, as the associated favorites models would remove entries when
they became invalid, and they wouldn't come back automatically when the
entry were to become valid again. In effect that means when you added one
of these actions to e.g. the Kicker sidebar and it became unavailable
it would disappear until re-added anyways.
I can imagine use cases where dynamic behavior would be useful to have -
let's say disabling Shutdown/Reboot while a critical system update is
being performed. But in that case we'd need to fix the favorites
behavior and add some way to inform the user why the action is disabled
for a good user experienced anyhow.
M +32 -23 applets/kicker/plugin/systemmodel.cpp
M +3 -1 applets/kicker/plugin/systemmodel.h
https://invent.kde.org/plasma/plasma-workspace/commit/fcdbbda3965d73900c415071ad882f550994fdc2
--
You are receiving this mail because:
You are watching all bug changes.
