https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #204 from caulier.gil...@gmail.com --- Hi Marcel, Sorry for my late response but i'm very busy in my office. >Should I run Digikam with the address sanitizer enabled? Both. First without, and in second if it continue to crash, with ASAN. >In my opinion we could close this huge bug and open new bugs for new problems, >>is that all right? Not yet. Memory leak is fixed but a crash still here typically with PreviewEngine. Maik work on it. >Why didn't you defined the constructors in a c++11 way? Instead of making it >private you could use delete or instead of implement an empty >constructor/destructor, default could be used. Or did I miss a technical >detail about that? You don't miss anything. Both method are valid, but : 1/ Other classes use C++0x implementation to disable constructors/destructor/operators. We need to still homogeneous everywhere as amount of source code is really huge. If we differ, this will become the hel to maintain. 2/ Don't forget MSVC : this compiler is a shit. C++ support is a pain, sure better with MSVC 2019, but M$ is so far than G++ and Clang to support standard. If you look into MSVC 2019, there is a plugin to use Clang instead native M$ compiler. In fact M$ continue to introduce more and more and more Open Source tools/codes/modules in Windows stuff. What's the next stage ? replace Windows kernel by Linux kernel ??? In fact KDE CI still to use MSVC 2017. So we need to not support totally C++11 yet. 3/ I'm not against whole C++11 standard at all, but some keywords as auto make code opaque and do not help in readbility. Also, why the compiler will automatically cast the target class with auto in a better way that the developper ??? I dislike also the labda method which make the code as a puzzle, as Javascript (excepted for some use where Lambda method can help to improve bianry compatibility but this must not generalized at all). 4/ Clang-tidy is a nice CLI tool to patch automatically all C++0x to C++11. I see an higher activity in Exiv2 project to port all codes to C++11, and clang-tidy is used in background. We will do the same later, but a specific release must be done only for this kind of changes to check for regressions. Gilles -- You are receiving this mail because: You are watching all bug changes.
