https://bugs.kde.org/show_bug.cgi?id=425829
Ahmad Samir <a.samir...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.75
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/fram
| |eworks/kio/commit/fdd7c47c8
| |5d5d6dbf21e05e7a0d6afcf383f
| |1d24
Status|ASSIGNED |RESOLVED
--- Comment #10 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit fdd7c47c85d5d6dbf21e05e7a0d6afcf383f1d24 by Ahmad Samir.
Committed on 21/09/2020 at 12:26.
Pushed by dfaure into branch 'master'.
OpenUrlJob: handle all text scripts consistently
Previously we only handled application/x-shellscript, but there are other
scripts; a script is technically a file that inherits both text/plain and
application/x-executable, e.g. .sh, .csh, .py, perl scripts ...etc. Treat
all those mime types the way we handled shell scripts:
- if it's not a local url, or isn't executable we open it in the preferred
text editor
- if it's executable either show the OpenOrExecute dialog or execute
directly depending on how the job is configured
The mimetype world is a confusing one:
- Executables, this includes .exe files (MS Windows); and
"application/x-executable"
and "application/x-sharedlib", this depends on various parameters (e.g.
stripped executables are x-sharedlib, the same executable if not stripped
is x-executable...)
- Scripts: shell, python, perl... etc scripts, which are text files that
can be executed or opened as text.
Adjust the unit test.
Related: bug 425177
FIXED-IN: 5.75
M +43 -13 autotests/openurljobtest.cpp
M +2 -0 autotests/openurljobtest.h
M +40 -25 src/gui/openurljob.cpp
https://invent.kde.org/frameworks/kio/commit/fdd7c47c85d5d6dbf21e05e7a0d6afcf383f1d24
--
You are receiving this mail because:
You are watching all bug changes.
