https://bugs.kde.org/show_bug.cgi?id=425875

Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/krita/commit/a599a55ec
                   |                            |b0800b5ec86978e61a6512a2fcb
                   |                            |70ee

--- Comment #9 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit a599a55ecb0800b5ec86978e61a6512a2fcb70ee by Dmitry Kazakov.
Committed on 11/09/2020 at 11:47.
Pushed by dkazakov into branch 'krita/4.3'.

Fix crash in ColorSmudge paintop with animated GIH brushes

The crash happened because dabRect and actual dab were calculated for
different brush indexes in the animated brush.

Before the patch, the switch of the index happened implicitly in
a call to KisBrush::brushIndex(). Now there are no implicit switches,
instead, the user is obliged to call KisBrush::prepareForSeqNo() before
doing brush generation.

Most of the times, tracking of seqNo is handled by the dab caching
system.

M  +1    -7    libs/brush/kis_brush.cpp
M  +5    -15   libs/brush/kis_brush.h
M  +2    -11   libs/brush/kis_brushes_pipe.h
M  +6    -11   libs/brush/kis_imagepipe_brush.cpp
M  +1    -2    libs/brush/kis_imagepipe_brush.h
M  +6    -11   libs/brush/kis_text_brush.cpp
M  +1    -2    libs/brush/kis_text_brush.h
M  +7    -1    plugins/paintops/libpaintop/kis_dab_cache.cpp
M  +1    -1    plugins/paintops/libpaintop/kis_dab_cache_base.cpp
M  +2    -0    plugins/paintops/spray/spray_brush.cpp
M  +1    -0    plugins/paintops/spray/spray_brush.h

https://invent.kde.org/graphics/krita/commit/a599a55ecb0800b5ec86978e61a6512a2fcb70ee

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to