https://bugs.kde.org/show_bug.cgi?id=423305
Jan Paul Batrina <jpmbatrin...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jpmbatrin...@gmail.com
--- Comment #4 from Jan Paul Batrina <jpmbatrin...@gmail.com> ---
Hello, I might have found the cause of this issue.
KDeclarative's KeySequenceItem started as a clone of KXmlGui's KKeySequence.
git blame shows that 1a919c88 is when this happens, and for some reason, the
KKeyServer::isShiftAsModifierAllowed check is omitted.
(links to the lines)
https://invent.kde.org/frameworks/kxmlgui/-/blob/master/src/kkeysequencewidget.cpp#L769
https://invent.kde.org/frameworks/kdeclarative/-/blob/master/src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp#L457
Readding the check fixes this bug, but my limited testing does not guarantee it
not introducing new ones or resulting to regressions, especially since it was
conciously omitted before.
While this fixes the case with Meta as modifier, it does not work with any
other modifier (or just shift + num) from what I tested. After that issue is
resolved, then only the keys hardcoded into the check are allowed to be with
Shift.
https://invent.kde.org/frameworks/kwindowsystem/-/blob/master/src/kkeyserver.cpp#L96
--
You are receiving this mail because:
You are watching all bug changes.
