https://bugs.kde.org/show_bug.cgi?id=423538
Stefan Brüns <stefan.bru...@rwth-aachen.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stefan.bruens@rwth-aachen.d
| |e
--- Comment #1 from Stefan Brüns <stefan.bru...@rwth-aachen.de> ---
For a complete, correct implementation, you have to:
- Fetch the cached directory thumbnail
- Get the base folder icon (thats the reason KFileItem::iconName is used)
-> If the base icon changed, DoRecomposite=true
- Iterate the directory, for each entry up to 4:
-- create the URL MD5
-- read the MTime
-- check if the thumb is cached and if the MTime matches (1)
--- if not, (Re)Create the item thumbnail
-> DoRecomposite=true
- If DoRecomposite, create the directory thumbnail, else fetch
So, you need the following metadata in the dir thumbnail:
- base icon name and theme (still not sufficient, appearance may change)
- URL MD5, MTime
Now, the next complication is, directory thumbnails are ThumbSequences, so you
get one cached dir thumb for subitems 1-4, one for 5-8, 9-12, ...
Do you really see compositing the icon as some kind of bottleneck?
(1) This can either be done per individual thumbnail, or, in your proposal,
from a composite key in the directory thumbnail. If you don't save the MTime in
the directory thumb meta, you have to load each item thumbnail.
--
You are receiving this mail because:
You are watching all bug changes.
