https://bugs.kde.org/show_bug.cgi?id=334618
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/netw
| |ork/kdenetwork-filesharing/
| |commit/01a6bda31bbc32d54bef
| |49111765aabbb771d153
Version Fixed In| |20.12
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Harald Sitter <sit...@kde.org> ---
Git commit 01a6bda31bbc32d54bef49111765aabbb771d153 by Harald Sitter.
Committed on 12/08/2020 at 14:37.
Pushed by sitter into branch 'master'.
give add/remove errors a GUI
previously we'd ignore the returned errors leaving the user hanging when
adding a share fails and not even telling them why.
we now route errors on add/remove through somewhat generic
kmessagebox-based reporting tech.
unfortunately this is fairly excessive WRT string mapping because
ksambashare sports one enum for everything so API-wise a call to save()
could return UserShareAclOk but in practice that of course cannot happen
because that'd mean nothing. as such many of the strings are overly
generic because they cannot practically appear on weak context actions
like save().
very meh.
this depends on the new lastSystemErrorString() API in KIO to stringify
the majority of failure scenarios here, which come out of samba's 'net'
command
trying to share /tmp now produces a kmessagebox informing the user that
the dir cannot be shared
FIXED-IN: 20.12
M +1 -1 CMakeLists.txt
M +90 -3 samba/filepropertiesplugin/sambausershareplugin.cpp
M +4 -0 samba/filepropertiesplugin/sambausershareplugin.h
https://invent.kde.org/network/kdenetwork-filesharing/commit/01a6bda31bbc32d54bef49111765aabbb771d153
--
You are receiving this mail because:
You are watching all bug changes.
