https://bugs.kde.org/show_bug.cgi?id=424638

Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/krita/commit/26c61baaf
                   |                            |cad95a3d6dcd40d0b7af53073b1
                   |                            |fa63
             Status|CONFIRMED                   |RESOLVED

--- Comment #5 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 26c61baafcad95a3d6dcd40d0b7af53073b1fa63 by Dmitry Kazakov.
Committed on 03/08/2020 at 22:10.
Pushed by dkazakov into branch 'master'.

Fix crash when moving a Transform Mask with the Move Tool

The patch does two things:

1) MoveStrokeStrategy should not try to request node->projection()
   unconditionally, because transform masks don't have them. Instead,
   the strategy should request current level of detail directly from
   the image.

2) The patch also fixes image() pointer in the masks. The pointer
   should be passed directly in the mask's constructor.

M  +3    -3    libs/image/kis_effect_mask.cc
M  +1    -1    libs/image/kis_effect_mask.h
M  +2    -2    libs/image/kis_filter_mask.cpp
M  +1    -1    libs/image/kis_filter_mask.h
M  +3    -3    libs/image/kis_mask.cc
M  +1    -1    libs/image/kis_mask.h
M  +8    -13   libs/image/kis_selection_mask.cpp
M  +0    -2    libs/image/kis_selection_mask.h
M  +2    -2    libs/image/kis_transform_mask.cpp
M  +1    -1    libs/image/kis_transform_mask.h
M  +3    -3    libs/image/kis_transparency_mask.cc
M  +1    -1    libs/image/kis_transparency_mask.h
M  +9    -4    libs/image/lazybrush/kis_colorize_mask.cpp
M  +1    -1    libs/image/lazybrush/kis_colorize_mask.h
M  +3    -3    libs/image/tests/kis_async_merger_test.cpp
M  +1    -1    libs/image/tests/kis_colorize_mask_test.cpp
M  +1    -1    libs/image/tests/kis_crop_processing_visitor_test.cpp
M  +16   -29   libs/image/tests/kis_filter_mask_test.cpp
M  +0    -1    libs/image/tests/kis_filter_mask_test.h
M  +1    -1    libs/image/tests/kis_image_test.cpp
M  +1    -1    libs/image/tests/kis_layer_style_projection_plane_test.cpp
M  +3    -3    libs/image/tests/kis_layer_test.cpp
M  +10   -7    libs/image/tests/kis_mask_test.cpp
M  +2    -2    libs/image/tests/kis_paint_layer_test.cpp
M  +6    -20   libs/image/tests/kis_projection_leaf_test.cpp
M  +10   -19   libs/image/tests/kis_transform_mask_test.cpp
M  +1    -6    libs/image/tests/kis_transparency_mask_test.cpp
M  +0    -1    libs/image/tests/kis_transparency_mask_test.h
M  +10   -10   libs/image/tests/kis_walkers_test.cpp
M  +3    -3    libs/libkis/Document.cpp
M  +1    -2    libs/libkis/FilterMask.cpp
M  +1    -1    libs/ui/dialogs/kis_dlg_filter.cpp
M  +4    -5    libs/ui/kis_mask_manager.cc
M  +1    -1    libs/ui/tests/KisPaintOnTransparencyMaskTest.cpp
M  +2    -6    libs/ui/tests/kis_file_layer_test.cpp
M  +6    -12   libs/ui/tests/util.h
M  +2    -1    libs/ui/tool/strokes/move_stroke_strategy.cpp
M  +1    -1    plugins/impex/libkra/kis_kra_load_visitor.cpp
M  +10   -10   plugins/impex/libkra/kis_kra_loader.cpp
M  +3    -3    plugins/impex/libkra/kis_kra_loader.h
M  +2    -2    plugins/impex/libkra/tests/kis_kra_saver_test.cpp
M  +7    -14   plugins/impex/libkra/tests/util.h
M  +1    -2    plugins/impex/psd/psd_loader.cpp
M  +1    -1    plugins/impex/xcf/kis_xcf_import.cpp
M  +1    -1   
plugins/tools/tool_transform2/tests/test_animated_transform_parameters.cpp
M  +1    -1    sdk/tests/empty_nodes_test.h
M  +1    -2    sdk/tests/qimage_based_test.h

https://invent.kde.org/graphics/krita/commit/26c61baafcad95a3d6dcd40d0b7af53073b1fa63

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to