https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #9 from Julian Seward <jsew...@acm.org> ---
(In reply to Carl Love from comment #3)
> Created attachment 130174 [details]
> Adds the support for prefix instructions
>
> 0002-ISA-3.1-Instruction-Prefix-Support.patch
>
> Adds the support for prefix instructions
Oops, missed a comment for this patch:
@@ -28401,11 +28764,47 @@ static UInt get_VSX60_opc2(UInt opc2_full, UInt
theInstr)
+static Bool dis_nop_prefix ( UInt prefixInstr, UInt theInstr )
+{
...
+ return PREFIX_NOP_INVALID;
This seems not-correct from a types point of view. dis_nop_prefix is declared
to return a Bool,
but PREFIX_NOP_INVALID is -1. I imagine this only compiles because of how lame
C's type system
is. Can you fix it so that Bool values are only True or False?
@@ -28598,6 +29000,35 @@ DisResult disInstr_PPC_WRK (
+ int ret;
+ ret = dis_nop_prefix( prefixInstr, theInstr);
+ if (ret == True)
+ goto decode_success;
+ else if (ret == PREFIX_NOP_INVALID)
+ goto decode_failure;
Related problem here; pls fix (`ret` being sometimes True and sometimes
PREFIX_NOP_INVALID given
that they have different types)
--
You are receiving this mail because:
You are watching all bug changes.
