https://bugs.kde.org/show_bug.cgi?id=423214

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.19.3
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/kwin/commit/8b9472e0bfcf
                   |                            |f8cb7467ee3055282a133a80834
                   |                            |9

--- Comment #3 from Nate Graham <n...@kde.org> ---
Git commit 8b9472e0bfcff8cb7467ee3055282a133a808349 by Nate Graham, on behalf
of Ismael Asensio.
Committed on 25/06/2020 at 15:44.
Pushed by ngraham into branch 'Plasma/5.19'.

[kcm/kwinrules] Fix types property for NET::AllTypesMask

When the user selects all of the types or none of them, the "types"
property must be set to a special value (`NET::AllTypesMask = -1`),
different than the sum of all the flags together.

This re-implements this behaviour as the old KCM, fixing some heuristics
that prevented finding the rule corresponding to the current window.

The enum name that handles this property has been changed to `NetTypes`
to make it more explicit.
FIXED-IN: 5.19.3

TEST PLAN:
1. Open the `Application specific settings` on a window via menu
2. Select every "Window Type" (or none of them)
3. Give the rule a different name than the default and save
4. Open it again and check that the same rule is found

M  +1    -1    kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml
M  +4    -3    kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml
M  +6    -5    kcmkwin/kwinrules/ruleitem.cpp
M  +1    -1    kcmkwin/kwinrules/ruleitem.h
M  +2    -2    kcmkwin/kwinrules/rulesmodel.cpp

https://invent.kde.org/plasma/kwin/commit/8b9472e0bfcff8cb7467ee3055282a133a808349

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to